Add tests for UnusedMethod with overridden methods in private interfaces. #5457
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces. I am now less convinced that the _finding_ was wrong, though the _fix_ is certainly unhelpful. The example in a bug does seem to be genuinely unused in that the method on the interface is not visible outside the class, and isn't called within it. The fix won't compile though. PiperOrigin-RevId: 859119202
copybara-service
bot
force-pushed
the
test_858569251
branch
from
9b2cc8e to
0f7f677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for UnusedMethod with overridden methods in private interfaces.
I am now less convinced that the finding was wrong, though the fix is certainly unhelpful. The example in a bug does seem to be genuinely unused in that the method on the interface is not visible outside the class, and isn't called within it. The fix won't compile though.