Rename sharding_names to sharding_metadata #5089
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanklesaria
force-pushed
the
sharding_metadata
branch
4 times, most recently
from
5cbafeb to
6611d4b
Compare
cgarciae
reviewed
Nov 25, 2025
flax/nnx/variablelib.py
Outdated
| def __getattr__(self, name: str) -> tp.Any: | ||
| if name == 'sharding_names': # for backward compatibility | ||
| warnings.warn("'sharding_names' is deprecated. Use 'sharding_metadata' instead.", DeprecationWarning) | ||
| return self.sharding_metadata |
Collaborator
There was a problem hiding this comment.
we should use has_metadata and get_metadata in the lines bellow and teach these methods how to handle sharding_names.
Collaborator
Author
There was a problem hiding this comment.
I note that get_metadata makes a copy of the metadata whenever you call it. This isn't the case when we use the getattr method here normally. Does this matter?
samanklesaria
force-pushed
the
sharding_metadata
branch
from
c430cfd to
3e96343
Compare
IvyZX
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the variable sharding API. Specifically: