Fix return value when payload update fails #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckungler
approved these changes
Jan 21, 2026
ASAN complains about -1 typecasted to `enum payload_update_err` when `payload_update_erase` fails in `libhoth_payload_update` This commit introduces a new return value `PAYLOAD_UPDATE_ERASE_FAIL` and returns it when `payload_update_erase` fails in `libhoth_payload_update`
xorptr
force-pushed
the
payload_update_test_enum_asan
branch
from
bd43812 to
97db6ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASAN complains about -1 typecasted to
enum payload_update_errwhenpayload_update_erasefails inlibhoth_payload_updateThis commit introduces a new return value
PAYLOAD_UPDATE_ERASE_FAILand returns it whenpayload_update_erasefails inlibhoth_payload_update