Wasmtime: remaps for coverage #5392
Conversation
catenacyber
force-pushed
the
wasmtimecov
branch
from
3428f94 to
a5247e0
Compare
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
I always find bash a bit, uh, esoteric to read...
In any case though looks good to me, thanks!
projects/wasmtime/build.sh
Outdated
There was a problem hiding this comment.
Could this have a comment for the purpose of what's happening? (basically just ensuring that absolute paths are used everywhere in debuginfo and such)
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks for your help here!
|
@inferno-chromium could we merge this ? |
Can you check CI failures, are they related to this change, can you maybe push again to see if they still happen. if not, leave a comment and we can merge. |
catenacyber
force-pushed
the
wasmtimecov
branch
from
0d19f74 to
b5cf156
Compare
|
CI is happier except for coverage failure which seems unrelated |
|
Thanks again for this @catenacyber, we got our first successful build today as a result. @inferno-chromium if I go to https://oss-fuzz.com/ and click "total coverage" it links me to https://oss-fuzz.com/coverage-report/job/libfuzzer_asan_wasmtime/latest which gives me " Failed to get coverage report. (alex@alexcrichton.com) ". Is that something that needs to be configured on y'all's end? Or should I just wait a day or so for things to propagate? |
|
There is one available here |
|
Oh wow, thanks! How did you end up finding the link to that? |
|
Just clicked a link to one of my projects and replaced the name ;-) |
|
And now your link https://oss-fuzz.com/coverage-report/job/libfuzzer_asan_wasmtime/latest works (and redirects to mine) |
3 participants
cc @alexcrichton cf #5366 (comment)
This should fix wasmtime coverage build