Skip to content

Conversation

@Artoria2e5
Copy link

  • A few quotes are added back to remove the possibility of the shell even wasting time on trying to word-split
  • read -r for no mangling of backslashes
  • double-bracketed [[ ]] test for quote-free fun
  • change echo to printf '%s\n' for robustness against strange names starting with a dash
  • %q quoting for eval to guard against trivial injections

* A few quotes are added back to remove the possibility of the shell even wasting time on trying to word-split
* read -r for no mangling of backslashes
* double-bracketed [[ ]] test for quote-free fun
* change echo to printf '%s\n' for robustness against strange names starting with a dash
* %q quoting for eval to guard against trivial injections
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Artoria2e5
Copy link
Author

CLA signed, how do I make it recheck?

@google-cla
Copy link

google-cla bot commented Aug 14, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants