Skip to content

Conversation

@YATIN072007
Copy link

Updated the broken RFC links in the docs (fixes #189).

Also made small changes in src/CMakeLists.txt to fix the build on Windows/MSVC by adding NASM detection and adjusting some compiler problems/complications .

@google-cla
Copy link

google-cla bot commented Jan 18, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@YATIN072007
Copy link
Author

YATIN072007 commented Jan 18, 2026

@HamdaanAliQuatil
Kindly review...

@jonasfj
Copy link
Member

jonasfj commented Jan 26, 2026

PR #246 suggests this PR should not be landed.

I haven't reviewed any of it yet, but PR for a PR that hasn't landed suggests we should land this.

@YATIN072007
Copy link
Author

@jonasfj @HamdaanAliQuatil
Fixed the key leak issue which was generated in the first two commits, kindly review

@HamdaanAliQuatil
Copy link
Collaborator

Hey @YATIN072007 - looks like this PR has some bleed-through from #243. I’m seeing changes related to making examples self-contained/runnable, which isn’t part of this issue.

Could you split those into a PR #243 and revert them here so we can land this one quickly?

@YATIN072007 YATIN072007 force-pushed the issue-189-rfc-links branch 2 times, most recently from cffc081 to 2fa2077 Compare January 29, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use canonical link for all RFC references

3 participants