[clippy] Be more permissive with safety comments #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
clippy-unsafe-blocks
branch
from
0daf769 to
87536de
Compare
joshlf
force-pushed
the
clippy-unsafe-blocks
branch
from
87536de to
d203a77
Compare
jswrenn
previously approved these changes
Sep 19, 2023
joshlf
force-pushed
the
clippy-unsafe-blocks
branch
from
d203a77 to
be9cc4e
Compare
joshlf
commented
Sep 21, 2023
auto-merge was automatically disabled
September 21, 2023 14:12
Pull request was converted to draft
joshlf
force-pushed
the
clippy-unsafe-blocks
branch
from
00d2ab5 to
3acca64
Compare
Set the following Clippy configuration variables, which we set to `true`: - `accept-comment-above-statement` - `accept-comment-above-attributes`
joshlf
force-pushed
the
clippy-unsafe-blocks
branch
from
3acca64 to
1e493fe
Compare
jswrenn
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the following Clippy configuration variables to
true:accept-comment-above-statementaccept-comment-above-attributes