Skip to content

Conversation

@AustinWise
Copy link

The Google.Cloud.VertexAI.Extensions assembly references types from Microsoft.Bcl.AsyncInterfaces like IAsyncEnumerable. The Google.Cloud.VertexAI.Extensions Nuget package needs to declare a dependency on the Microsoft.Bcl.AsyncInterfaces package so that a compatible version is restored when consumed from .NET Core projects.

Fixes #15350

@AustinWise AustinWise requested a review from a team as a code owner January 1, 2026 17:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinWise, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical dependency issue within the Google.Cloud.VertexAI.Extensions NuGet package. By explicitly declaring a dependency on Microsoft.Bcl.AsyncInterfaces, it guarantees that necessary asynchronous interface types, such as IAsyncEnumerable, are always available and correctly restored when the package is used in .NET Core environments. This change enhances the stability and reliability of the package for consumers.

Highlights

  • Dependency Resolution: Added a direct package reference to Microsoft.Bcl.AsyncInterfaces in the Google.Cloud.VertexAI.Extensions project file.
  • Runtime Stability: Ensures that IAsyncEnumerable and other types from Microsoft.Bcl.AsyncInterfaces are correctly resolved, preventing potential runtime issues in .NET Core projects consuming the Google.Cloud.VertexAI.Extensions NuGet package.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

…d.VertexAI.Extensions

The `Google.Cloud.VertexAI.Extensions` assembly references types from `Microsoft.Bcl.AsyncInterfaces` like `IAsyncEnumerable`. The `Google.Cloud.VertexAI.Extensions` Nuget package needs to declare a dependency on the `Microsoft.Bcl.AsyncInterfaces` package so that a compatible version is restored when consumed from .NET Core projects.

Fixes googleapis#15350
@AustinWise AustinWise force-pushed the austin/VertexAI.Extensions-async branch from 0c24915 to f9600b7 Compare January 1, 2026 17:21
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an explicit package reference for Microsoft.Bcl.AsyncInterfaces to the Google.Cloud.VertexAI.Extensions project. This is a good change that makes a transitive dependency direct, which improves dependency resolution robustness for the package's consumers. The change is correct and follows existing patterns in the project file. I see no issues with this change.

Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the analysis - I've looked into this before, but ended up getting confused (and possibly didn't try building a project using .NET 10).

Would like @amanda-tarafa to look before merging though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatched dependency version when using Google.Cloud.VertexAI.Extensions

2 participants