-
Notifications
You must be signed in to change notification settings - Fork 396
Reference Microsoft.Bcl.AsyncInterfaces from package Google.Cloud.VertexAI.Extensions #15353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reference Microsoft.Bcl.AsyncInterfaces from package Google.Cloud.VertexAI.Extensions #15353
Conversation
Summary of ChangesHello @AustinWise, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical dependency issue within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…d.VertexAI.Extensions The `Google.Cloud.VertexAI.Extensions` assembly references types from `Microsoft.Bcl.AsyncInterfaces` like `IAsyncEnumerable`. The `Google.Cloud.VertexAI.Extensions` Nuget package needs to declare a dependency on the `Microsoft.Bcl.AsyncInterfaces` package so that a compatible version is restored when consumed from .NET Core projects. Fixes googleapis#15350
0c24915 to
f9600b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an explicit package reference for Microsoft.Bcl.AsyncInterfaces to the Google.Cloud.VertexAI.Extensions project. This is a good change that makes a transitive dependency direct, which improves dependency resolution robustness for the package's consumers. The change is correct and follows existing patterns in the project file. I see no issues with this change.
jskeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the analysis - I've looked into this before, but ended up getting confused (and possibly didn't try building a project using .NET 10).
Would like @amanda-tarafa to look before merging though.
The
Google.Cloud.VertexAI.Extensionsassembly references types fromMicrosoft.Bcl.AsyncInterfaceslikeIAsyncEnumerable. TheGoogle.Cloud.VertexAI.ExtensionsNuget package needs to declare a dependency on theMicrosoft.Bcl.AsyncInterfacespackage so that a compatible version is restored when consumed from .NET Core projects.Fixes #15350