test(storage-scenarios): rampup tasks slowly #4166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid transient errors by slowly ramping up the worker threads.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4166 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 186 186
Lines 6947 6947
=======================================
Hits 6578 6578
Misses 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
previously approved these changes
Jan 6, 2026
| args: &Args, | ||
| client: &Storage, | ||
| ) -> anyhow::Result<Object> { | ||
| tokio::time::sleep(Duration::from_millis(10) * task as u32).await; |
Member
There was a problem hiding this comment.
s/Duration::from_millis(10)/args.rampup_period/ ?
Collaborator
Author
There was a problem hiding this comment.
Fixed by using a different argument.
dbolduc
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid transient errors by slowly ramping up the worker threads.
Motivated by #4085 where I had to run 1024 tasks at a time.