Skip to content

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Dec 30, 2025

Create EnhancedBigtableStub with BigtableClientContext. Before the change when EnhancedBigtableStub is cloesd, it only calls close on the background resources in ClientContext. However otel and internal otel are created on BigtableClientContext and nothing calls it to close them.

@mutianf mutianf requested review from a team as code owners December 30, 2025 17:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 30, 2025
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026
igorbernstein2
igorbernstein2 previously approved these changes Jan 6, 2026
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nits

@mutianf mutianf merged commit 3d0a6d9 into googleapis:main Jan 6, 2026
25 checks passed
@mutianf mutianf deleted the context branch January 6, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants