fix: move batch metrics to internal views #2749
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
kongweihan
previously approved these changes
Jan 6, 2026
kongweihan
reviewed
Jan 6, 2026
|
|
||
| for (Map.Entry<InstrumentSelector, View> entry : | ||
| BuiltinMetricsConstants.getAllViews().entrySet()) { | ||
| meterProvider.registerView(entry.getKey(), entry.getValue()); |
Contributor
There was a problem hiding this comment.
I can't comment on code outside of this area?..
This getAllViews() function- should it be named something like getExternalViews()?
kongweihan
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch metrics are defined with BigtableClient schema, so it needs to be part of the internal views instead of public views.