-
Notifications
You must be signed in to change notification settings - Fork 42
chore: librarian update image pull request: 20260113T170734Z #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated 'librarian' update that has failed for the google-cloud-datastore library. As a result, it includes the deletion of a vast number of critical source files, which would completely break the package. This is a critical issue. The only intentional change seems to be the generator image update in .librarian/state.yaml. Please investigate the generation failure and revert all the file deletions before this PR can be merged.
I am having trouble creating individual review comments. Click here to see my feedback.
setup.py (1-106)
The deletion of setup.py and numerous other source files is highly problematic. As noted in the pull request description, the generation for google-cloud-datastore failed. These file deletions are likely an unintended side effect of that failure. Please revert these deletions to avoid breaking the package.
noxfile.py (1-539)
This file, essential for testing and linting, has been deleted. This appears to be part of a broader issue in this PR where a failed generation process for google-cloud-datastore has led to the removal of many critical files. Please revert this deletion.
docs/README.rst (1-201)
The main README file for the library has been deleted. This is likely an error caused by the failed generation process mentioned in the PR description. Please restore this file.
google/cloud/datastore_v1/init.py (1-226)
The main __init__.py for the datastore_v1 client has been deleted, which would break all imports from this package. This is a critical error, likely caused by the failed generation. This deletion must be reverted.
google/cloud/datastore_admin_v1/init.py (1-174)
The main __init__.py for the datastore_admin_v1 client has been deleted, which would break all imports from this package. This is a critical error, likely caused by the failed generation. This deletion must be reverted.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
Generation failed for