Skip to content

Conversation

@Pulkit0110
Copy link
Member

Adding a support to pass generation in the constructor of MRD. It is done to make it compatible with the other public interfaces.

Earlier, generation_number was exposed as the parameter which would still be valid after these changes. But using generation is more preferred.

@Pulkit0110 Pulkit0110 requested review from a team as code owners January 29, 2026 08:44
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Jan 29, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the AsyncMultiRangeDownloader to standardize its object generation parameter, aligning it with the naming conventions used across other public interfaces. The change ensures that while new code will use the more consistent generation parameter, existing implementations relying on generation_number will continue to operate without disruption, providing a smooth transition path for developers.

Highlights

  • Parameter Renaming: The generation_number parameter in the AsyncMultiRangeDownloader constructor and create_mrd method has been renamed to generation for consistency with other public interfaces.
  • Backward Compatibility: Backward compatibility is maintained for the generation_number parameter. Existing code using generation_number will continue to function, but generation is now the preferred parameter.
  • Parameter Conflict Handling: A TypeError will now be raised if both generation and generation_number parameters are provided simultaneously, guiding users to adopt the new generation parameter.
  • Internal Updates and Docstrings: Internal references within the class and associated docstrings have been updated to reflect the new generation parameter.
  • Unit Test Enhancements: New unit tests have been added to verify the backward compatibility of generation_number and to confirm that the TypeError is correctly raised when both parameters are used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Pulkit0110 Pulkit0110 changed the title Update mrd generation feat: update generation for MRD Jan 29, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AsyncMultiRangeDownloader to use generation instead of generation_number for consistency with other interfaces, while maintaining backward compatibility. The changes are well-implemented and include corresponding test updates for the new behavior. My main feedback is to remove some duplicated logic between create_mrd and __init__ to improve maintainability, as detailed in my specific comment.

@Pulkit0110 Pulkit0110 closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants