Skip to content

Conversation

@Pulkit0110
Copy link
Member

Adding a support to pass generation in the constructor of MRD. It is done to make it compatible with the other public interfaces.

Earlier, generation_number was exposed as the parameter which would still be valid after these changes. But using generation is more preferred.

@Pulkit0110 Pulkit0110 requested review from a team as code owners January 29, 2026 09:36
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 29, 2026
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 29, 2026
@Pulkit0110 Pulkit0110 enabled auto-merge (squash) January 29, 2026 09:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the API consistency of the AsyncMultiRangeDownloader by standardizing the parameter name for specifying an object's generation. The primary goal is to make the interface more intuitive and consistent across the library, while carefully implementing a backward-compatible solution to avoid breaking existing client code. This ensures a smoother transition for users adopting the updated API.

Highlights

  • API Consistency: The AsyncMultiRangeDownloader class now uses the generation parameter instead of generation_number in its constructor and create_mrd method, aligning with other public interfaces.
  • Backward Compatibility: The change maintains backward compatibility by still accepting generation_number via **kwargs in the constructor. If both generation and generation_number are provided, a TypeError is raised to prevent ambiguity.
  • Test Coverage: New unit tests have been added to specifically verify the backward compatibility for generation_number and to ensure the correct error handling when both generation parameters are used simultaneously.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the AsyncMultiRangeDownloader to use the generation parameter instead of generation_number for consistency, while maintaining backward compatibility. The changes are logical and include appropriate tests for the new behavior. The suggestion to enhance the API's robustness by checking for unexpected keyword arguments is valid and has been retained. The other changes are minor stylistic improvements.

@Pulkit0110 Pulkit0110 merged commit 08bc708 into googleapis:main Jan 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants