Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Conversation

@atotic
Copy link

@atotic atotic commented Nov 21, 2014

without this div, core-icon icons repeat if size does not match

without this div, core-icon icons repeat if size does not match
@ssorallen
Copy link
Contributor

Styles should target classes with the key selector rather than the tag name where possible and appropriate. This could become:

core-icon.html

icon.style.backgroundImage = ...;
icon.classList.add('core-icon-icon');

core-icon.css

html /deep/ .core-icon-icon {
  background-position: center;
  background-repeat: none;
  background-size: 100%;
}

Or pull request #25 adds the necessary background-repeat on the icon's style object.

@atotic atotic closed this May 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants