Fix justification for use of skrifa vs manual scaling #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmedrano
force-pushed
the
wmedrano
branch
7 times, most recently
from
af2be9c to
a45ebc9
Compare
wmedrano
changed the title
dfrg
approved these changes
Jan 5, 2026
- Refactor the code to make choice more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fonts can either be scaled by Skrifa or with manual transforms. The TODO comment mis-attributes drawing inaccuracies to colr fonts, but it is actually due to the use of transforms. Transforms (especially with translation) should be applied after scaling.