feat: [#423] Optimize setup #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Related Issue: goravel/goravel#423
This pull request updates the setup process for installing and uninstalling the Postgres service provider, focusing on improving how the module import path is managed and simplifying the setup code. The main changes involve using a new
setupvariable to encapsulate setup logic, updating references frommodulePathtomoduleImport, and slightly restructuring method chaining for clarity.Setup process improvements:
setupvariable to store the result ofpackages.Setup(os.Args), streamlining subsequent method calls and reducing code duplication.modulePathwithmoduleImportby callingsetup.Paths().Module().Import(), ensuring the correct import path is used throughout the setup and uninstall logic. [1] [2]Code structure and clarity:
InstallandUninstallby chaining directly from thesetupvariable and removing unnecessary line breaks, making the code easier to read and maintain. [1] [2]Dependency update:
github.com/goravel/frameworkdependency ingo.modto a newer commit, ensuring compatibility with the latest framework changes.✅ Checks