Compat: getCurrentTexture and textureBindingViewDimension #4553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check thte textures returned from canvas context getCurrentTexture have `textureBindingViewDimension` and that it's undefined in core and is `'2d'` in compatibility mode.
kainino0x
approved these changes
Jan 8, 2026
kainino0x
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that textures returned from canvas context getCurrentTexture have
textureBindingViewDimensionand that it's undefined in core and is'2d'in compatibility mode.I don't know what other implementations would have an issue here but the current spec requires these to work just like any other texture and chromium has some special cases here. This test failed in chromium until it was fixed.