-
Notifications
You must be signed in to change notification settings - Fork 422
added Volume and Area to MeshMeasurements for simple requests #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nsmela
wants to merge
2
commits into
gradientspace:dotnet8
Choose a base branch
from
nsmela:volume-helper
base: dotnet8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,6 +183,70 @@ public static Vector2d VolumeArea( DMesh3 mesh, IEnumerable<int> triangles, | |
|
|
||
|
|
||
|
|
||
| /// <summary> | ||
| /// Compute volume and surface area of triangles of mesh. | ||
| /// Return value is (volume,area) | ||
| /// Note that if triangles don't define closed region, volume is probably nonsense... | ||
| /// </summary> | ||
| public static Vector2d VolumeArea(DMesh3 mesh) | ||
| { | ||
| double mass_integral = 0.0; | ||
| double area_sum = 0; | ||
| foreach (int tid in mesh.TriangleIndices()) | ||
| { | ||
| mesh.GetTriVertices(tid, out Triangle3d tri); | ||
| Vector3d N = (tri.V1 - tri.V0).Cross(tri.V2 - tri.V0); | ||
|
|
||
| area_sum += 0.5 * N.Length; | ||
| mass_integral += N.x * (tri.V0.x + tri.V1.x + tri.V2.x); | ||
| } | ||
|
|
||
| return new Vector2d(mass_integral * (1.0 / 6.0), area_sum); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /// <summary> | ||
| /// Compute entire volume of mesh. | ||
| /// Return value is volume | ||
| /// Note that if triangles don't define closed region, volume is probably nonsense... | ||
| /// </summary> | ||
| public static double Volume(DMesh3 mesh) | ||
| { | ||
| double mass_integral = 0.0; | ||
|
|
||
| foreach (int tid in mesh.TriangleIndices()) | ||
| { | ||
| mesh.GetTriVertices(tid, out Triangle3d tri); | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| Vector3d N = (tri.V1 - tri.V0).Cross(tri.V2 - tri.V0); | ||
| mass_integral += N.x * (tri.V0.x + tri.V1.x + tri.V2.x); | ||
| } | ||
|
|
||
| return mass_integral * (1.0 / 6.0); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /// <summary> | ||
| /// Compute surface area of triangles of mesh. | ||
| /// Return value is area | ||
| /// Note that if triangles don't define closed region, volume is probably nonsense... | ||
| /// </summary> | ||
| public static double Area(DMesh3 mesh) | ||
| { | ||
| double area_sum = 0; | ||
| foreach (int tid in mesh.TriangleIndices()) | ||
| { | ||
| mesh.GetTriVertices(tid, out Triangle3d tri); | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be more efficient to have the out reference Triangle3d tri declared before the for loop so it's not created in each loop? |
||
| Vector3d N = (tri.V1 - tri.V0).Cross(tri.V2 - tri.V0); | ||
| area_sum += 0.5 * N.Length; | ||
| } | ||
|
|
||
| return area_sum; | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /// <summary> | ||
| /// Compute area of one-ring of mesh vertex by summing triangle areas. | ||
| /// If bDisjoint = true, we multiple each triangle area by 1/3 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.