Windows exporter integration #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
Mar 18, 2021
mattdurham
commented
Mar 23, 2021
rfratto
reviewed
Mar 24, 2021
Member
rfratto
left a comment
rfratto
left a comment
There was a problem hiding this comment.
This is really coming along well, thank you for putting effort into this. I'm not super happy about reflection, and I'm worried its cognitive cost is too high compared to keeping the lines of code smaller.
… current valid value.
… current valid value.
Change to explicit setting of map
rfratto
approved these changes
Mar 25, 2021
Member
rfratto
left a comment
rfratto
left a comment
There was a problem hiding this comment.
LGTM, though this needs to be rebased to pick up the latest changes to the integrations interface, otherwise it's going to fail to build after merging.
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
…to windows_exporter_integration
mattdurham
added a commit
that referenced
this pull request
Nov 11, 2021
* Testing * Windows Exporter support * Add untracked files * Checkin example converting to custom config * Scary reflect for getting the values * Smaller item feedback in PR * Add linting exception * Update the changelog * Fix MSSQL config * Reorder functions and fix comments. * Clean up var names * Change to explicit setting of map * minor formatting * Switch to explicit mapping * Add some checks on sync * Use far simpler method, under the assumption an empty string is not a current valid value. * Use far simpler method, under the assumption an empty string is not a current valid value. * Add vendor files * Add build tags so windows specific items dont get included * Fix linting error * Fix linting error * Fix linting error * Fix linting error * Fix linting error * Update CHANGELOG.md Co-authored-by: Robert Fratto <robertfratto@gmail.com> * PR feedback of cleaning vars * Rearranging files for non windows usage. * Cross platform support * Cross platform support * Add beta verbiage Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This add windows_exporter to the list of default exporters for the windows platform. This currently uses a fork of windows_exporter located at github.com/grafana/windows_exporter. It uses the same type of configuration has the normal windows_exporter.
Which issue(s) this PR fixes
Closes #285
Notes to the Reviewer
PR Checklist