Typings refactoring #293
Merged
Typings refactoring #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 29, 2025 13:27
ykornilov
requested review from
Marginy605,
flops and
jhoncool
as code owners
Contributor
|
Preview is ready. |
Marginy605
requested changes
Dec 29, 2025
Comment on lines
-23
to
-28
| | 'context' | ||
| | 'noOverlay' | ||
| | 'focusable' | ||
| | 'globalParams' | ||
| | 'editMode' | ||
| | 'settings' |
Collaborator
There was a problem hiding this comment.
Why did you removed 'globalParams', 'settings' and 'context'?
Collaborator
Author
There was a problem hiding this comment.
in DashKitProps they are optional but in DashKitCtxShape they are required, so I added them in separate fields in DashKitCtxShape
Marginy605
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.