Modified configuration in lf_base_interop_profile.py , py-json/interop_connectivity.py and Added robo in Port reset test

[Sidartha-CT]

No description provided.

[memnochproxy]

I would prefer you do this with f-strings, eg:

f'--es ssid "{cur_ssid}" '

Is there a reason you are using \" inside a single quote? Do the backslashes fix something that resulting command?

[memnochproxy]

Please do not mix multiple string formatting methods. You have some " %s "%foo strings in there. Let's standardise on f-strings, please. You also have some "{}".format() calls, change those to f-strings too.

[memnochproxy]

Please address inline structural comments.
I think the lines in this file are getting rather long, too.
PEP8 requires line length of 79 chars.

[memnochproxy]

This else is an unnecessary level of indentation. Remove the else and go up one level of indentation.

[Sidartha-CT]

Yes, Jed. I initially added the else for readability, but you’re right it creates an unnecessary level of indentation since the if statement already returns. I’ve removed the else, added a comment for clarity, and made the changes in the same commit via rebasing.

[memnochproxy]

use fstrings

[Sidartha-CT]

Sure Jed, I’ve replaced them with f-strings and will follow this as the standard style going forward.

[memnochproxy]

you can rewrite this as a series of guard clauses to put your continue statement at the top of the loop, not in an else.

if (coord_key not in self.port_reset_data 
    or angle_key not in slef.port_reset_data[coord_key]
    or .....):
    continue
reset_dict = ...

[Sidartha-CT]

Sure Jed, I've added those specific changes, will improve and follow this same pattern when it's required.

[memnochproxy]

you can rewrite this as a series of guard clauses to put your continue statement at the top of the loop, not in an else.

if (coord_key not in ...
    or ...
    or .....):
    continue
reset_dict = ...

[Sidartha-CT]

Sure Jed, I've added those specific changes. Thank you for reviewing the code.

[Sidartha-CT]

I would prefer you do this with f-strings, eg:

f'--es ssid "{cur_ssid}" '

Is there a reason you are using \" inside a single quote? Do the backslashes fix something that resulting command?

Hi Jed (@memnochproxy ) ,
Thanks for the inputs.
With the recent configuration changes added in the 5.5.2 build, we observed that Android configuration using the old CLI was failing. When we manually triggered the configuration via Batch Modify, we noticed in the lanforge_log that backslashes were being applied to the ssid and password arguments in the CLI also with additional auto_wifi flag.

To maintain consistency, we have implemented the same handling in our scripts that include Android configurations.

Please let me know if you have any concerns or if further changes are required.

[Sidartha-CT]

Please address inline structural comments. I think the lines in this file are getting rather long, too. PEP8 requires line length of 79 chars.

Yes, Jed (@memnochproxy ). The inline comments were added by previous developers during the initial development of this script. To add robot-specific logic for the port reset with bit priority, I moved that block into a separate helper so it can be reused. That said, we will clean up the inline structural comments and ensure the file adheres to PEP8 standards, including the 79-character line length, in the future commits.
Thank you!