lf_webpage.py: Fixed issue while running http in mixed traffic test. #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smileyrekiere
left a comment
smileyrekiere
left a comment
There was a problem hiding this comment.
What problem is this change fixing? Normally we can to have the undeclared parameters be none.
Collaborator
Author
In the mixed traffic test, coordinates and rotations are not initialized, so they are passed as null. If we directly run from lf_webpage.py, these values default to an empty string ("") in args parser. Because of this, the mixed traffic test passes null, and when the code tries to split it, it fails since None cannot be split, causing errors in coordinates_list and rotation_list.
|
VERIFIED CLI: python3 lf_mixed_traffic.py --mgr 192.168.207.78 / --upstream_port eth1 / --mixed_traffic_loop 1 / --real / --use_default_config / --pre_cleanup / --parallel / --test_duration 1m / --target www.google.com / --ping_interval 5 / --side_a_min 0 / --side_b_min 10000000 / --traffic_type lf_tcp / --tos VO,VI,BE,BK / --ftp_file_sizes 5MB / --direction Download / --http_file_size 5MB / --mc_tos VO / --side_b_min_bps 10000000 / --tests 1 2 3 4 5 Signed-off-by: litincandela <litin.ommi@candelatech.com>
litincandela
force-pushed
the
robot_http
branch
from
92c8f68 to
095f40b
Compare
smileyrekiere
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.