Git builds #21
Open
Git builds #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2018 16:48
(This requires watchman to be preinstalled on the system)
Fixes a build issue where `rule` was not a function see facebook/relay#2428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #19 is under review, this PR should allow third parties to run the
madycommand when using a git repo in their package.json definitions. This is done with the prepare hook, to build the executable.The funtional part of this branch is in the first commit, and shouldn't change any pre-existing behaviour. I needed to upgrade graphql due to some build issues in the second commit, I've never worked with graphql, so even though the tests succeed and the app runs locally, additional verification might be required.