fix: findAll not accessing undefined #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @Nilet ! Let me explain that method is used to map an old version of data that the user might have since the data structure has changed from version 1 to 2... If there is a time property on any object in the list, it is the old version, so it is iterated item by item, correcting the data. unfortunately the solution as it is cannot be merged, as it only takes away the error, but the software loses the correction that is made :/ Let me know if you want help submitting a retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two similar functions basically had the same behavior where they always tried to access the first item and it would crash if there was none. This bug would actually make it impossible to create the first item and it would permanently return undefined.