Skip to content

Conversation

@izzy-me
Copy link
Member

@izzy-me izzy-me commented Nov 6, 2025

Fixes #8282

What changes did you make?

  • I added new profile information to the leadership page.

Why did you make the changes (we will use this info to test)?

  • I updated the leadership section on the Civic Tech Jobs page to accurately reflect current leadership.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-11-05 at 5 00 28 PM
Visuals after changes are applied Screenshot 2025-11-07 at 5 50 12 PM

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izzy-me-update-proj-profile-8282 gh-pages
git pull https://github.com/izzy-me/hfla-website.git update-proj-profile-8282

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Unassigned by Bot Previously-prioritized issues that bot places in "New Issue Approval" labels Nov 6, 2025
@izzy-me izzy-me changed the title Resolved issue #8282 by updating civic tech jobs page Resolved issue by updating civic tech jobs page Nov 6, 2025
@myronchen-git myronchen-git self-requested a review November 6, 2025 20:39
@myronchen-git
Copy link
Member

Availability: 3 - 5 PM
ETA: 11/6/2025

@myronchen-git myronchen-git removed the Status: Unassigned by Bot Previously-prioritized issues that bot places in "New Issue Approval" label Nov 6, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on completing your first issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The pull request title is named properly.
  • Code changes have been correctly made.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.
  • In the issue, action items have correctly been checked off.

Changes that need to be made

  • In this pull request's description, the why section needs to describe the underlying reason why the changes are made. In this case, it needs to explain the purpose of adding in a new member to the civic tech jobs page. For first issues, the reason can usually be derived from the overview of the originating issue.

    Also, please remove the extra unused bullets.

  • In this pull request's description, the CodeQL Alerts section needs to be checked off.

  • In the screenshots section, please remove the text "image" that is also linked.

  • In the screenshots section, you still have to add an image for visual changes after the commit is applied, even though your docker is not working. If you are still not able to fix your docker deployment, please ask for help by setting the status to "questions" in the project assignment in the originating issue and leaving a comment, or asking on Slack.


Optional recommendations

  • In the originating issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.

  • In this pull request's description, the what section item can be more specific. "New information" is quite vague and can be replaced by saying that a new member has been added to the leadership.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Nov 6, 2025
@github-actions github-actions bot added the Status: Unassigned by Bot Previously-prioritized issues that bot places in "New Issue Approval" label Nov 7, 2025
@myronchen-git myronchen-git removed the Status: Unassigned by Bot Previously-prioritized issues that bot places in "New Issue Approval" label Nov 7, 2025
@izzy-me
Copy link
Member Author

izzy-me commented Nov 8, 2025

Congratulations on completing your first issue.

Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The pull request title is named properly.
  • Code changes have been correctly made.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.
  • In the issue, action items have correctly been checked off.

Changes that need to be made

  • In this pull request's description, the why section needs to describe the underlying reason why the changes are made. In this case, it needs to explain the purpose of adding in a new member to the civic tech jobs page. For first issues, the reason can usually be derived from the overview of the originating issue.
    Also, please remove the extra unused bullets.
  • In this pull request's description, the CodeQL Alerts section needs to be checked off.
  • In the screenshots section, please remove the text "image" that is also linked.
  • In the screenshots section, you still have to add an image for visual changes after the commit is applied, even though your docker is not working. If you are still not able to fix your docker deployment, please ask for help by setting the status to "questions" in the project assignment in the originating issue and leaving a comment, or asking on Slack.

Optional recommendations

  • In the originating issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.
  • In this pull request's description, the what section item can be more specific. "New information" is quite vague and can be replaced by saying that a new member has been added to the leadership.

@izzy-me izzy-me closed this Nov 8, 2025
@izzy-me izzy-me reopened this Nov 8, 2025
@izzy-me
Copy link
Member Author

izzy-me commented Nov 8, 2025

Changes implemented from request. More detailed pull request info added plus additional image to show what the result of the added code looks like.

@izzy-me izzy-me requested a review from myronchen-git November 8, 2025 01:55
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes.

Can you also change the title to be more specific than "resolved issue" and include the person being added?

I apologize for changing my mind.

@izzy-me izzy-me changed the title Resolved issue by updating civic tech jobs page Updated leadership profile section on Civic Tech Jobs page to include Gowthami Cherukuri Nov 8, 2025
@izzy-me izzy-me requested a review from myronchen-git November 8, 2025 03:14
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good job.

@t-will-gillis t-will-gillis removed the Complexity: Small Take this type of issues after the successful merge of your second good first issue label Nov 9, 2025
@xnealcarson xnealcarson self-requested a review November 10, 2025 03:16
Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present
  • The changes made are applicable and clean.

Suggested Changes

  • I have none, and you have addressed all of @myronchen-git 's requested changes

Great job with this issue @izzy-me . Thanks for your work on this!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 10, 2025
@xnealcarson xnealcarson merged commit da93186 into hackforla:gh-pages Nov 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Gowthami Cherukuri

5 participants