-
-
Notifications
You must be signed in to change notification settings - Fork 843
Updated leadership profile section on Civic Tech Jobs page to include Gowthami Cherukuri #8408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated leadership profile section on Civic Tech Jobs page to include Gowthami Cherukuri #8408
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 3 - 5 PM |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on completing your first issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- Code changes have been correctly made.
- In the issue, you've correctly assigned yourself.
- In the issue, the project and its status has been correctly assigned.
- In the issue, action items have correctly been checked off.
Changes that need to be made
-
In this pull request's description, the
whysection needs to describe the underlying reason why the changes are made. In this case, it needs to explain the purpose of adding in a new member to the civic tech jobs page. For first issues, the reason can usually be derived from the overview of the originating issue.Also, please remove the extra unused bullets.
-
In this pull request's description, the CodeQL Alerts section needs to be checked off.
-
In the screenshots section, please remove the text "image" that is also linked.
-
In the screenshots section, you still have to add an image for visual changes after the commit is applied, even though your docker is not working. If you are still not able to fix your docker deployment, please ask for help by setting the status to "questions" in the project assignment in the originating issue and leaving a comment, or asking on Slack.
Optional recommendations
-
In the originating issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.
-
In this pull request's description, the
whatsection item can be more specific. "New information" is quite vague and can be replaced by saying that a new member has been added to the leadership.
|
|
Changes implemented from request. More detailed pull request info added plus additional image to show what the result of the added code looks like. |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes.
Can you also change the title to be more specific than "resolved issue" and include the person being added?
I apologize for changing my mind.
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Good job.
xnealcarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present
- The changes made are applicable and clean.
Suggested Changes
- I have none, and you have addressed all of @myronchen-git 's requested changes
Great job with this issue @izzy-me . Thanks for your work on this!
Fixes #8282
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied