Skip to content

first issue:Add github-handle for Glen Paul Florendo (Fixes #7800) #8412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdaca19xx merged 1 commit into from
Nov 10, 2025
Merged

first issue:Add github-handle for Glen Paul Florendo (Fixes #7800) #8412

kdaca19xx merged 1 commit into from
Nov 10, 2025

Conversation

@shu1513
Copy link
Member

@shu1513 shu1513 commented Nov 7, 2025 •
edited
Loading

Fixes #7800

What changes did you make?

  • Replace:
  • name: Glen Paul Florendo
    with:
  • name: Glen Paul Florendo
    github-handle:

Why did you make the changes (we will use this info to test)?

  • Added basic GitHub handle

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
      I don't know what these are
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@HackforLABot HackforLABot mentioned this pull request Nov 7, 2025
Open
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b shu1513-update-lucky-parking-issue-7800 gh-pages
git pull https://github.com/shu1513/website.git update-lucky-parking-issue-7800

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 7, 2025
xnealcarson
xnealcarson requested changes Nov 9, 2025
View reviewed changes
Copy link
Member

@xnealcarson xnealcarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shu1513 ! We appreciate you working on this issue.

Things Done Well

The issue has the correct 'commit into': "hackforla:gh-pages".
the 'commit from' and 'collaborator' names match.
The linked issue is present: 'Fixes #7800'.

Suggested Changes

  • Please check the first box of the 'Code QL Alerts' to confirm that you've checked for alerts

Otherwise, great job on this issue! Once you've applied the requested changes, we can go ahead with approval and merging! Thanks @shu1513 .

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Nov 9, 2025
kdaca19xx
kdaca19xx requested changes Nov 9, 2025
View reviewed changes
Copy link
Member

@kdaca19xx kdaca19xx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort shu1513!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. I read/understood it.

  • Your edits in the Files Changed tab looks good.

  • I checked Docker to confirm the appearance. Looks good to me, but I want to double check with @t-will-gillis.

Suggestions

  • Please use the info in the Overview section of #7800 to answer "Why did you make the changes?"

  • Did you mean to include screenshots? If so, they can't be seen under the "Visuals before changes are applied" and "Visuals after changes are applied" sections. Let's ask a team lead if they're needed (I don't think they are.).

@t-will-gillis, I have a question about the Merge Team note in #7800. I'll ask/Slack you soon.

@shu1513
Copy link
Member Author

shu1513 commented Nov 9, 2025 via email

@xnealcarson
Copy link
Member

xnealcarson commented Nov 9, 2025 •
edited
Loading

Hey @shu1513 . Below your 'Why did you make the changes' section of your Pull Request there is the 'Code QL Alerts' section, which are the alerts I am referring to. You can check for these below the comments section, underneath 'Changes Requested'. As long as the section says "all checks have passed", you should be fine, but you still need to check the first box in the 'Code QL Alerts' section that says "I have checked this PR for CodeQL alerts and none were found", so reviewers and merge team know that you checked for them. Thanks!

@HackforLABot HackforLABot mentioned this pull request Nov 9, 2025
Open
@shu1513
Copy link
Member Author

shu1513 commented Nov 9, 2025 via email

@shu1513
Copy link
Member Author

shu1513 commented Nov 9, 2025 via email

@kdaca19xx
Copy link
Member

kdaca19xx commented Nov 9, 2025 •
edited
Loading

Hi @shu1513!

You're right. This issue doesn't require visuals. So you can just put something like "No visual changes to website" somewhere under Screenshots of Proposed Changes To The Website. Hope this helps.

@HackforLABot HackforLABot mentioned this pull request Nov 9, 2025
Open
@shu1513
Copy link
Member Author

shu1513 commented Nov 10, 2025 via email

kdaca19xx
kdaca19xx approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work, shu1513!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. I read/understood it.

  • Your edits in the Files Changed tab looks good.

  • The appearance of the page looks good in Docker.

  • You revised your answer to "Why did you make the changes?"

  • You confirmed there were no visuals under the "Screenshots of Proposed Changes To The Website" section

Suggestions

none

xnealcarson
xnealcarson approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @shu1513 ! Thanks for making the changes. Just a sidenote for future pull requests: after making requested changes, you should want to re-request reviews from all reviewers, especially those who initially requested changes. Many thanks again and a nice job with this issue!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 10, 2025
@kdaca19xx kdaca19xx merged commit 5c7a0a6 into hackforla:gh-pages Nov 10, 2025
16 checks passed
@shu1513
Copy link
Member Author

shu1513 commented Nov 10, 2025 via email

@shu1513 shu1513 deleted the update-lucky-parking-issue-7800 branch November 14, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdaca19xx kdaca19xx kdaca19xx approved these changes

@xnealcarson xnealcarson xnealcarson approved these changes

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add github-handle for Glen Paul Florendo in lucky-parking.md

3 participants

@shu1513 @xnealcarson @kdaca19xx