Skip to content

Conversation

@izzy-me
Copy link
Member

@izzy-me izzy-me commented Nov 10, 2025

Fixes #7289

What changes did you make?

  • I added the "github-handle" variable to Asad Haider's leadership info in _projects/design-systems.md (the Design Systems project on the website.

Why did you make the changes (we will use this info to test)?

  • I made these changes to keep the backend of the page up to date and consistent. Several other members on this page already have their own "github-handle" variable associated with their name. Eventually, all members listed will have this variable to replace the "github" and "picture" variables, reducing redundancy in the file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izzy-me-add-handle-7289 gh-pages
git pull https://github.com/izzy-me/hfla-website.git add-handle-7289

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 10, 2025
@aymeviviana aymeviviana self-requested a review November 10, 2025 21:22
@aymeviviana
Copy link
Member

Review ETA: 5PM PST
Availability: 2-5 PM Mon, Tues, Wed

@Mykola-Lopushenko
Copy link
Member

Review ETA: 6 PM 11/11/25
Availability: 6-8 PM Monday-Friday

Copy link
Member

@aymeviviana aymeviviana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this issue, @izzy-me !

  • Pull request contains the correct branch
  • CodeQL Alerts box is properly checked
  • PR notes are clear and easy to understand
  • Linked issue is properly added
  • Source code changes are applicable and clean

Approving this PR!

Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @izzy-me!

Great job!
Done Correctly:

  • The branch setup and linking to the issue have been done correctly.
  • The code updates follow the project format and naming conventions.
  • The webpage was tested locally with Docker and displays correctly at all screen sizes.

PR approved! Thank you for your contribution!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 10, 2025
@daras-cu daras-cu merged commit 8ff7734 into hackforla:gh-pages Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Asad Haider in design-systems.md

5 participants