-
-
Notifications
You must be signed in to change notification settings - Fork 843
Updated _projects/design-systems to include "github-handle" variable under A. Haider's information #8414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 5PM PST |
|
Review ETA: 6 PM 11/11/25 |
aymeviviana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this issue, @izzy-me !
- Pull request contains the correct branch
- CodeQL Alerts box is properly checked
- PR notes are clear and easy to understand
- Linked issue is properly added
- Source code changes are applicable and clean
Approving this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @izzy-me!
Great job!
Done Correctly:
- The branch setup and linking to the issue have been done correctly.
- The code updates follow the project format and naming conventions.
- The webpage was tested locally with Docker and displays correctly at all screen sizes.
PR approved! Thank you for your contribution!
Fixes #7289
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website.