Skip to content

Conversation

@bragelbytes
Copy link
Member

@bragelbytes bragelbytes commented Nov 11, 2025

Fixes #8375

What changes did you make?

  • Added Ryan Keller project profile to website

Why did you make the changes (we will use this info to test)?

  • Followed instructions in the issue

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied update-project-profile-8375-before
Visuals after changes are applied update-project-profile-8375-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b bragelbytes-update-project-profile-8375 gh-pages
git pull https://github.com/bragelbytes/website.git update-project-profile-8375

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.5pt Can be done in 3 hours or less epic Issue Making: Level 1 Make issues from a template and a spreadsheet labels Nov 11, 2025
@aymeviviana aymeviviana self-requested a review November 11, 2025 19:24
@aymeviviana
Copy link
Member

Review ETA: 4 PM PST 11/11/25
Availability: 10AM - 4PM Tuesday, Wednesday

Copy link
Member

@aymeviviana aymeviviana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your excellent work on this issue/PR, @bragelbytes !

Everything looks really good, just added a minor suggestion below for the future.

Done Correctly:

  • The Pull Request uses the correct branch
  • The linked issue is present and correctly formatted
  • The CodeQL Alerts section is correctly completed
  • Code update looks applicable and clean
  • Before and after screenshots are provided
  • New profile looks consistent across multiple viewports

Suggestions:

  • Some additional context in the “Why did you make the changes?” section will be helpful for future PR’s. For instance, something brief like “Ryan Keller is a new member of the Merge Team. Adding his profile to the “Current Project Team” section on https://www.hackforla.org/projects/website.

Approving this PR!

@cadenramey cadenramey self-requested a review November 11, 2025 21:38
@cadenramey
Copy link
Member

cadenramey commented Nov 11, 2025

Review ETA: 3pm 11/11/25
Availability: M-F 2-5pm

Copy link
Member

@cadenramey cadenramey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bragelbytes great job!

  1. PR is in the correct branch
  2. Issue is linked correctly
  3. Changes in browser are done correctly
  4. Files changed are correct

Needs fixing:

Just echoing @aymeviviana suggestion, please leave a more detailed comment on why you made the changes you did just for extra clarity practice especially for future PR's.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Nov 11, 2025
@daras-cu
Copy link
Member

Hi @bragelbytes, thanks for working on this but the original issue #8398 was not ready to be assigned yet, it was still in the Questions/In Review column. Please only take issues from the Prioritized Backlog column, those have been approved as ready to work on.

I'm going to unassign you from #8398 and close this PR to give that issue's author a chance to finish the corrections that need to be made to the issue. If you'd like to reassign yourself once it's available you can, but we do have plenty of good first issues currently in the Prioritized Backlog so it will be quicker to choose another one from there to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

epic good first issue Good for newcomers Issue Making: Level 1 Make issues from a template and a spreadsheet P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: HackforLA Website

4 participants