-
-
Notifications
You must be signed in to change notification settings - Fork 843
add Ryan Keller project profile #8415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ryan Keller project profile #8415
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4 PM PST 11/11/25 |
aymeviviana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your excellent work on this issue/PR, @bragelbytes !
Everything looks really good, just added a minor suggestion below for the future.
Done Correctly:
- The Pull Request uses the correct branch
- The linked issue is present and correctly formatted
- The CodeQL Alerts section is correctly completed
- Code update looks applicable and clean
- Before and after screenshots are provided
- New profile looks consistent across multiple viewports
Suggestions:
- Some additional context in the “Why did you make the changes?” section will be helpful for future PR’s. For instance, something brief like “Ryan Keller is a new member of the Merge Team. Adding his profile to the “Current Project Team” section on https://www.hackforla.org/projects/website.
Approving this PR!
|
Review ETA: 3pm 11/11/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bragelbytes great job!
- PR is in the correct branch
- Issue is linked correctly
- Changes in browser are done correctly
- Files changed are correct
Needs fixing:
Just echoing @aymeviviana suggestion, please leave a more detailed comment on why you made the changes you did just for extra clarity practice especially for future PR's.
|
Hi @bragelbytes, thanks for working on this but the original issue #8398 was not ready to be assigned yet, it was still in the Questions/In Review column. Please only take issues from the Prioritized Backlog column, those have been approved as ready to work on. I'm going to unassign you from #8398 and close this PR to give that issue's author a chance to finish the corrections that need to be made to the issue. If you'd like to reassign yourself once it's available you can, but we do have plenty of good first issues currently in the Prioritized Backlog so it will be quicker to choose another one from there to work on. |
Fixes #8375
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied