-
-
Notifications
You must be signed in to change notification settings - Fork 843
Added github handle for Leroy Tung #8416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4 PM PST 11/11/25 |
aymeviviana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your excellent work on this PR, @ldaws003 !
Done Correctly:
- The Pull Request uses the correct branch
- The linked issue is present and correctly formatted
- The CodeQL Alerts section is correctly completed
- Code update is applicable and clean
- Change looks consistent across multiple screen sizes
Suggestions:
- For future PR’s you can delete the note at the top of the post that ends with “Delete this message if you joined this team via onboarding.”
- A bit more context in the “Why did you make the changes” section would be helpful. Perhaps something like “This change is part of a rollout that will replace GitHub info in leadership team profiles with a single variable.”
|
Review ETA 5pm 11/11/25 |
cadenramey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ldaws003 great job on the PR!
- PR done with the correct branch
- Linked issue correctly
- Correctly made no visual changes to site
- Correct file changed
Needs fixing:
Basically same as the suggestions made by @aymeviviana
- Please delete the top paragraph on the PR - start with Fixes #7333
- Please elaborate on why you made the changes you did (ie. why are we adding the github-handle variable?). This is just for clarity sake especially when you move to more complex issues, this section will become much more important.
cadenramey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the changes - everything looks great! Will go ahead and approve the request.
Fixes #7333
What changes did you make?
github-handle:under Leroy Tung's entry in _projects/youthjusticenav.mdWhy did you make the changes (we will use this info to test)?
githubandpicturevariables withgithub-handleCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)