Skip to content

Conversation

@ldaws003
Copy link
Member

@ldaws003 ldaws003 commented Nov 11, 2025

Fixes #7333

What changes did you make?

  • added github-handle: under Leroy Tung's entry in _projects/youthjusticenav.md

Why did you make the changes (we will use this info to test)?

  • this is part of an effort to reduce redundancy by replacing the github and picture variables with github-handle

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • I made changes to a md file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ldaws003-github-handle-7333 gh-pages
git pull https://github.com/ldaws003/website.git github-handle-7333

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 11, 2025
@aymeviviana aymeviviana self-requested a review November 11, 2025 18:12
@aymeviviana
Copy link
Member

Review ETA: 4 PM PST 11/11/25
Availability: 10AM - 4PM Tues & Wed

Copy link
Member

@aymeviviana aymeviviana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your excellent work on this PR, @ldaws003 !

Done Correctly:

  • The Pull Request uses the correct branch
  • The linked issue is present and correctly formatted
  • The CodeQL Alerts section is correctly completed
  • Code update is applicable and clean
  • Change looks consistent across multiple screen sizes

Suggestions:

  • For future PR’s you can delete the note at the top of the post that ends with “Delete this message if you joined this team via onboarding.”
  • A bit more context in the “Why did you make the changes” section would be helpful. Perhaps something like “This change is part of a rollout that will replace GitHub info in leadership team profiles with a single variable.”

@cadenramey cadenramey self-requested a review November 11, 2025 22:46
@cadenramey
Copy link
Member

Review ETA 5pm 11/11/25
Availability 2-5pm M-F

Copy link
Member

@cadenramey cadenramey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ldaws003 great job on the PR!

  1. PR done with the correct branch
  2. Linked issue correctly
  3. Correctly made no visual changes to site
  4. Correct file changed

Needs fixing:

Basically same as the suggestions made by @aymeviviana

  • Please delete the top paragraph on the PR - start with Fixes #7333
  • Please elaborate on why you made the changes you did (ie. why are we adding the github-handle variable?). This is just for clarity sake especially when you move to more complex issues, this section will become much more important.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Nov 11, 2025
@ldaws003 ldaws003 requested a review from cadenramey November 12, 2025 02:46
Copy link
Member

@cadenramey cadenramey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the changes - everything looks great! Will go ahead and approve the request.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 12, 2025
@daras-cu daras-cu merged commit 1315127 into hackforla:gh-pages Nov 13, 2025
17 checks passed
@ldaws003 ldaws003 deleted the github-handle-7333 branch November 13, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Leroy Tung in youthjusticenav.md

4 participants