-
-
Notifications
You must be signed in to change notification settings - Fork 843
Added GitHub handle for Rabia Shaikh #8422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitHub handle for Rabia Shaikh #8422
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4 pm PST, 11/14 |
izzy-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @shu1513! Congrats on completing a good first issue.
- pull request contains the correct branch
- CodeQL Alerts box properly checked
- Linked issue properly added
- source code changes are applicable and clean
One minor note: in future pull requests, make sure to be a little more specific when answering "why did you make the changes." You can just write a bullet about keeping the leadership section up to date by ensuring consistent variable use.
Thanks for the great work. Approving the PR!
|
Thank you!!
…________________________________
From: izzy-me ***@***.***>
Sent: Friday, November 14, 2025 8:49 PM
To: hackforla/website ***@***.***>
Cc: Shu Yang ***@***.***>; Mention ***@***.***>
Subject: Re: [hackforla/website] Fixes #7334 (PR #8422)
@izzy-me approved this pull request.
Great job, @shu1513<https://github.com/shu1513>! Congrats on completing a good first issue.
* pull request contains the correct branch
* CodeQL Alerts box properly checked
* Linked issue properly added
* source code changes are applicable and clean
One minor note: in future pull requests, make sure to be a little more specific when answering "why did you make the changes." You can just write a bullet about keeping the leadership section up to date by ensuring consistent variable use.
Thanks for the great work. Approving the PR!
—
Reply to this email directly, view it on GitHub<#8422 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CEPM2QNBMUFFNEPIWFL34Y55ZAVCNFSM6AAAAACMEUHWK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINRWG43DENJQGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Review ETA: 8 pm PST, 11/17 |
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shu1513!
Thank you for working on this issue.
Done Correctly:
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The CodeQL alerts have been correctly checked off.
- In the issue, you've correctly assigned yourself.
- In the issue, the project and its status has been correctly assigned.
- All action items in the issue have been checked off.
Changes that need to be made
- In the pull request title, please remove the issue number 7334. See contributing instructions on explaining this.
- Please add a short descriptive phrase to the PR title for clarity (e.g., what was changed or added).
Thank you for your contribution!
|
Thank you,
I went ahead and did that.
looks OK?
Shu
…________________________________
From: Mykola-Lopushenko ***@***.***>
Sent: Tuesday, November 18, 2025 5:02 AM
To: hackforla/website ***@***.***>
Cc: Shu Yang ***@***.***>; Mention ***@***.***>
Subject: Re: [hackforla/website] Fixes #7334 (PR #8422)
@Mykola-Lopushenko requested changes on this pull request.
Hi @shu1513<https://github.com/shu1513>!
Thank you for working on this issue.
Done Correctly:
* The merge from and to branches have been correctly set.
* The issue has been correctly linked.
* The CodeQL alerts have been correctly checked off.
* In the issue, you've correctly assigned yourself.
* In the issue, the project and its status has been correctly assigned.
* All action items in the issue have been checked off.
Changes that need to be made
* In the pull request title, please remove the issue number 7334. See contributing instructions<https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#i-complete-pull-request-1-update-pull-request-title> on explaining this.
* Please add a short descriptive phrase to the PR title for clarity (e.g., what was changed or added).
Thank you for your contribution!
—
Reply to this email directly, view it on GitHub<#8422 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CELVQBIJ7H64WC4S6WL35KR6RAVCNFSM6AAAAACMEUHWK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZVGQ3DIMRQHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great!
Next time, after you make your updates, please remember to click the Re-request review button so reviewers get notified :)
Great job!
|
Thank you!
…________________________________
From: Mykola-Lopushenko ***@***.***>
Sent: Wednesday, November 19, 2025 12:41 AM
To: hackforla/website ***@***.***>
Cc: Shu Yang ***@***.***>; Mention ***@***.***>
Subject: Re: [hackforla/website] Added GitHub handle for Rabia Shaikh (PR #8422)
@Mykola-Lopushenko approved this pull request.
You did great!
Next time, after you make your updates, please remember to click the Re-request review button so reviewers get notified :)
Great job!
—
Reply to this email directly, view it on GitHub<#8422 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CEKW2YGKEDZGZC6M6TD35O4EFAVCNFSM6AAAAACMEUHWK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOBQGIZTSMJXGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
sorry, where is the "re-request review" button?
…________________________________
From: Mykola-Lopushenko ***@***.***>
Sent: Wednesday, November 19, 2025 12:41 AM
To: hackforla/website ***@***.***>
Cc: Shu Yang ***@***.***>; Mention ***@***.***>
Subject: Re: [hackforla/website] Added GitHub handle for Rabia Shaikh (PR #8422)
@Mykola-Lopushenko approved this pull request.
You did great!
Next time, after you make your updates, please remember to click the Re-request review button so reviewers get notified :)
Great job!
—
Reply to this email directly, view it on GitHub<#8422 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CEKW2YGKEDZGZC6M6TD35O4EFAVCNFSM6AAAAACMEUHWK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOBQGIZTSMJXGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi @shu1513, thanks for taking on this issue! The "re-request review" button can be found in the "Reviewers" section of each PR, generally in the top right of the Conversation tab. You will see a circular arrow symbol next to each reviewer that has submitted a review, and if you click it it will notify them to review again. You'll want to click the button for each reviewer that you want to re-review. Here's an example from another PR: For the "Why did you make these changes" section, what you have is good for a GFI. However for future (and larger) issues, we would like to see the justification for the changes (i.e., why was this code change was needed and/or why you went with a specific approach). For example, I think @izzy-me's suggestion for this issue, "keeping the leadership section up to date by ensuring consistent variable use" is a good baseline. Great work knocking this issue out! I also approve! |
|
Thank you Ryan!!
…________________________________
From: Ryan Keller ***@***.***>
Sent: Wednesday, November 19, 2025 5:48 PM
To: hackforla/website ***@***.***>
Cc: Shu Yang ***@***.***>; Mention ***@***.***>
Subject: Re: [hackforla/website] Added GitHub handle for Rabia Shaikh (PR #8422)
[https://avatars.githubusercontent.com/u/34756033?s=20&v=4]ryanfkeller left a comment (hackforla/website#8422)<#8422 (comment)>
Hi @shu1513<https://github.com/shu1513>, thanks for taking on this issue!
The "re-request review" button can be found in the "Reviewers" section of each PR, generally in the top right of the Conversation tab. You will see a circular arrow symbol next to each reviewer that has submitted a review, and if you click it it will notify them to review again. You'll want to click the button for each reviewer that you want to re-review.
Here's an example from another PR:
image.png (view on web)<https://github.com/user-attachments/assets/9e0dc107-2029-4ad4-a048-b7bc49140918>
For the "Why did you make these changes" section, what you have is good for a GFI. However for future (and larger) issues, we would like to see the justification for the changes (i.e., why was this code change was needed and/or why you went with a specific approach). For example, I think @izzy-me<https://github.com/izzy-me>'s suggestion for this issue, "keeping the leadership section up to date by ensuring consistent variable use" is a good baseline.
Great work knocking this issue out! I also approve!
—
Reply to this email directly, view it on GitHub<#8422 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CENXULRYVSYHUIVQ32T35SUP5AVCNFSM6AAAAACMEUHWK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNJTHE2TMNBUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|

Fixes #7334
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website