Skip to content

Conversation

@shu1513
Copy link
Member

@shu1513 shu1513 commented Nov 14, 2025

Fixes #7334

What changes did you make?

  • Added GitHub handle for Rabia Shaikh

Why did you make the changes (we will use this info to test)?

  • Because the issue asks to add the GitHub-handle

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b shu1513-github-handle-Rabia-Shaikh-#7334 gh-pages
git pull https://github.com/shu1513/website.git github-handle-Rabia-Shaikh-#7334

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 14, 2025
@izzy-me izzy-me self-requested a review November 14, 2025 20:35
@izzy-me
Copy link
Member

izzy-me commented Nov 14, 2025

Review ETA: 4 pm PST, 11/14
Availability: 4-6 pm PST, 11/14

Copy link
Member

@izzy-me izzy-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shu1513! Congrats on completing a good first issue.

  • pull request contains the correct branch
  • CodeQL Alerts box properly checked
  • Linked issue properly added
  • source code changes are applicable and clean

One minor note: in future pull requests, make sure to be a little more specific when answering "why did you make the changes." You can just write a bullet about keeping the leadership section up to date by ensuring consistent variable use.

Thanks for the great work. Approving the PR!

@shu1513
Copy link
Member Author

shu1513 commented Nov 15, 2025 via email

@Mykola-Lopushenko Mykola-Lopushenko self-requested a review November 17, 2025 16:45
@Mykola-Lopushenko
Copy link
Member

Review ETA: 8 pm PST, 11/17
Availability: 6-9 pm PST, Mon-Fri

Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shu1513!

Thank you for working on this issue.
Done Correctly:

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The CodeQL alerts have been correctly checked off.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.
  • All action items in the issue have been checked off.

Changes that need to be made

  • In the pull request title, please remove the issue number 7334. See contributing instructions on explaining this.
  • Please add a short descriptive phrase to the PR title for clarity (e.g., what was changed or added).

Thank you for your contribution!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Nov 18, 2025
@shu1513 shu1513 changed the title Fixes #7334 Added GitHub handle for Rabia Shaikh Nov 18, 2025
@shu1513
Copy link
Member Author

shu1513 commented Nov 18, 2025 via email

@Mykola-Lopushenko Mykola-Lopushenko self-requested a review November 19, 2025 00:38
Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great!
Next time, after you make your updates, please remember to click the Re-request review button so reviewers get notified :)

Great job!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 19, 2025
@shu1513
Copy link
Member Author

shu1513 commented Nov 19, 2025 via email

@shu1513
Copy link
Member Author

shu1513 commented Nov 19, 2025 via email

@ryanfkeller
Copy link
Member

Hi @shu1513, thanks for taking on this issue!

The "re-request review" button can be found in the "Reviewers" section of each PR, generally in the top right of the Conversation tab. You will see a circular arrow symbol next to each reviewer that has submitted a review, and if you click it it will notify them to review again. You'll want to click the button for each reviewer that you want to re-review.

Here's an example from another PR:
image

For the "Why did you make these changes" section, what you have is good for a GFI. However for future (and larger) issues, we would like to see the justification for the changes (i.e., why was this code change was needed and/or why you went with a specific approach). For example, I think @izzy-me's suggestion for this issue, "keeping the leadership section up to date by ensuring consistent variable use" is a good baseline.

Great work knocking this issue out! I also approve!

@ryanfkeller ryanfkeller merged commit b0c1c54 into hackforla:gh-pages Nov 19, 2025
17 of 19 checks passed
@shu1513
Copy link
Member Author

shu1513 commented Nov 19, 2025 via email

@shu1513 shu1513 deleted the github-handle-Rabia-Shaikh-#7334 branch November 22, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Rabia Shaikh in youthjusticenav.md

4 participants