added github-handle variable to Seymour in Lucky Parking Project Team #8424
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
ETA: 11/14 at 6:20 pm |
izzy-me
left a comment
izzy-me
left a comment
There was a problem hiding this comment.
Hi @bragelbytes!
Great work here. Two minor edits:
- Make sure to fill out the CodeQL Alerts as part of the pull request. It looks like you don't have any so it should be good to go. Just make sure to mark that your changes are free of alerts.
- Try to be slightly more descriptive with question 2, i.e. you can say that each person listed requires this new variable so you are updating the file to be consistent with these guidelines.
Otherwise, great work! Once those minor edits are made, I can approve the PR.
- PR contains correct branch
- linked issue properly added
- source code changes are applicable and clean
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
|
ETA: 11/17 at 6:00 pm |
izzy-me
left a comment
izzy-me
left a comment
There was a problem hiding this comment.
Looks great! Thanks for making the requested changes. PR approved.
santiseccovidal
left a comment
santiseccovidal
left a comment
There was a problem hiding this comment.
Hi @bragelbytes good work with the code changes. Question 1 "What changes..." is alright but the second sentence is more geared towards Question 2 "Why...". Question 2 needs another answer, check out this PR and try to work on it #8419
Thanks for working on this
santiseccovidal
left a comment
santiseccovidal
left a comment
There was a problem hiding this comment.
Hi @bragelbytes well done, now the What and Why sections are more clear.
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
|
Hi @bragelbytes! Thanks for working on this issue - Just wanted to leave a comment to remind you to check of the completed items in the Action Items checklist in the issue. Thanks again! |
5 participants
Fixes #7802
What changes did you make?
Why did you make the changes (we will use this info to test)?
Each person in the list requires this variable so I updated it to be consistent with guidelines.
Eventually, github-handle will replace the github and picture variables to reduce redundancy.
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Changes are free from CodeQL alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes.