Chatbot4 #21
Open
Chatbot4 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| //print variable | ||
| console.log(chatbot) |
Contributor
There was a problem hiding this comment.
clean up your console logs
|
|
||
| }else if (question.includes("dog")){//if input includes dog below function will work | ||
|
|
||
| let image = new XMLHttpRequest(); //gives info from APIs |
Contributor
There was a problem hiding this comment.
I would abstract this into another function since this makes this function super long and doing too many things.. we want to make code as readable as possible
| image.send();//sends request | ||
|
|
||
| } else if (question.includes("alarm")){//if input includes dog below function will work | ||
| function delayedAlert(){ |
Contributor
There was a problem hiding this comment.
same for this, I would define the function outside the reply() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.