chatBot 4 #29
Open
chatBot 4 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatbot.js
Outdated
|
|
||
| ]; | ||
|
|
||
| //console.log(); |
Contributor
There was a problem hiding this comment.
Don't leave commented out lines in your code
chatbot.js
Outdated
|
|
||
| //console.log(); | ||
|
|
||
| function reply () |
Contributor
There was a problem hiding this comment.
make sure to use indentation to make your code clear
chatbot.js
Outdated
| let filterType = null; | ||
| const output = chatbot.filter(item => item.input === question); | ||
| if(question === ''){ return false; } | ||
| appendQ (question) |
Contributor
There was a problem hiding this comment.
there should be no space between your function name and (question)
chatbot3.js
Outdated
| ]; | ||
|
|
||
| /* | ||
| It should now look like this: |
Contributor
There was a problem hiding this comment.
Please remove your commented out lines
chatbot3.js
Outdated
| let question = document.getElementById('input').value; | ||
| let filterType = null; | ||
|
|
||
| let answer = chatbot.filter(function(item){ |
Contributor
There was a problem hiding this comment.
No need to make it into a long function, this can be done in one line as you did above
Contributor
|
Should have your logic for all parts in one file and create a new PR for each assignment rather than have 3 copies of the file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.