assignment completed #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Overall, good job - all the functionality is there, and you did a good job handling several inputs and outputs with different capitalizations. |
epq
reviewed
Sep 25, 2019
| console.log(question); | ||
|
|
||
| // statement to answer the question based on the index of the question. | ||
| if ( |
Collaborator
There was a problem hiding this comment.
This works just fine, but you can simplify it.
Since your question variable is converted to lowercase on line 15, you don't need to continue to call toLowerCase() on this variable.
Good job using map. You can save the result of chatInputsOutputs.inputs.map(v => v.toLowerCase() in a variable since you call this twice. It would also be easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.