Use base::rbind over plyr::rbind.fill #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first change where my confidence in the back-compatibility of the change falters a bit (see the change to
margin_dfsrequired to get the same behavior when the inputs mix ordered and non-ordered factors).It does pass
R CMD check, as well as 1000+ other downstream tests we have (of typical varying quality).It might be better to just switch to {dplyr} also, please LMK if that's what you prefer, though see this exploration of the differences for
rbind.fill()vs.bind_rows():https://gist.github.com/MichaelChirico/8df9b42e0e42d32828b34a641d33dc8c