Use stateName as the source of truth for StackRouterNavigator state e… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quality Currently, StackRouterNavigator compares states inconsistently. In the "pushState" method, it compares states via "state.stateName() == newState.stateName()". Elsewhere, it compares states using "state == newState". This leads to surprising behavior in the library. For example, if you push state with name "A", then push another state "A" with Flag.DEFAULT, the second push will no-op even if the two states aren't otherwise equal. But if you push a state with name "A", then push another state with Flag.CLEAR_TOP, clearTop won't clear the stack since a different equality check is used vs Flag.DEFAULT. This makes the library always use the state name as the source of truth for state equality, which seems like a more expected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…quality
Description:
Currently, StackRouterNavigator compares states inconsistently. In the "pushState" method, it compares states via "state.stateName() == newState.stateName()". Elsewhere, it compares states using "state == newState". This leads to surprising behavior in the library.
For example, if you push state with name "A", then push another state "A" with Flag.DEFAULT, the second push will no-op even if the two states aren't otherwise equal. But if you push a state with name "A", then push another state with Flag.CLEAR_TOP, clearTop won't clear the stack since a different equality check is used vs Flag.DEFAULT.
This makes the library always use the state name as the source of truth for state equality, which seems like a more expected behavior.
Related issue(s): RF-8841