Fix: Add operator_to_iso_vec support for EmbeddedOperator #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add control_api.jl, quantum_api.jl, and visualizations_api.jl literate docs - Update docs workflow and make.jl configuration
Fixes bug where SamplingProblem construction would fail when using an EmbeddedOperator as the goal in a UnitaryTrajectory. The issue was that operator_to_iso_vec only had a method for AbstractMatrix but not for EmbeddedOperator. When creating a SamplingProblem, the code tries to convert the goal operator to an isomorphic vector representation, which failed for EmbeddedOperator types. Changes: - Add operator_to_iso_vec method for EmbeddedOperator in embedded_operators.jl - Add test for operator_to_iso_vec with EmbeddedOperator - Add integration test for SamplingProblem with EmbeddedOperator goal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
SamplingProblemconstruction would fail when using anEmbeddedOperatoras the goal in aUnitaryTrajectory.Problem
The
operator_to_iso_vecfunction only had a method forAbstractMatrixbut not forEmbeddedOperator. WhenSamplingProblemtried to convert the goal operator to an isomorphic vector representation, it failed with:Solution
Added a new method
operator_to_iso_vec(op::EmbeddedOperator)that delegates to the existing method by passingop.operator.Changes
operator_to_iso_vecmethod forEmbeddedOperatorSamplingProblemwithEmbeddedOperatorTesting
operator_to_iso_vec(embedded_op)produces the same result asoperator_to_iso_vec(embedded_op.operator)SamplingProblemcan be constructed with anEmbeddedOperatorgoal