Skip to content

the input of URI.decode_www_form must be ASCII only string #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonhenHS wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

the input of URI.decode_www_form must be ASCII only string #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/code_review_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def show
if request.xhr? || !params[:update].blank?
render partial: 'show'
elsif target.path
path = URI.decode_www_form(target.path)
path = URI.decode_www_form(URI.encode(target.path))
action_name = target.action_type
rev_to = ''
rev_to = '&rev_to=' + target.rev_to if target.rev_to
Expand Down