Skip to content

Avoid unnecessary string copy when no log level is specified #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hnw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid unnecessary string copy when no log level is specified #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions level.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ type LevelFilter struct {
// will be set.
Writer io.Writer

badLevels map[LogLevel]struct{}
once sync.Once
badLevels map[LogLevel]struct{}
once sync.Once
maxLenOfLevel int
}

// Check will check a given line if it would be included in the level
Expand All @@ -40,7 +41,7 @@ func (f *LevelFilter) Check(line []byte) bool {
x := bytes.IndexByte(line, '[')
if x >= 0 {
y := bytes.IndexByte(line[x:], ']')
if y >= 0 {
if y >= 0 && y-1 <= f.maxLenOfLevel {
level = LogLevel(line[x+1 : x+y])
}
}
Expand Down Expand Up @@ -78,4 +79,10 @@ func (f *LevelFilter) init() {
badLevels[level] = struct{}{}
}
f.badLevels = badLevels

for _, level := range f.Levels {
if f.maxLenOfLevel < len(level) {
f.maxLenOfLevel = len(level)
}
}
}