Skip to content

Conversation

@andreasabel
Copy link
Member

@andreasabel andreasabel commented Jul 27, 2025

  • Remove trailing whitespace and turn tabs to spaces

  • Fix building testsuite (import conflict)

  • Make benchmarks build again (fix import conflicts)

Test and benchmarks can however not run in CI due to:

A hack to build it locally was to rename pretty to something else in the pretty.cabal file.
(Maybe this hack could be institutionalized in the CI using a patch that is applied before the build.)

@andreasabel
Copy link
Member Author

@dterei PR is ready.
Commits should be preserved. There is a larger commit that just fixes whitespace that should not be fused with the other commits.

Building the testsuite broke with GHC 9.8 because containers started
to depend on template-haskell which depends on pretty.
@andreasabel
Copy link
Member Author

Ok, the build of the testsuite is only finally breaking with GHC 9.8, so I included the testsuite in CI for some older versions of GHC (9.6 for ci.yml, 9.0/2 for Haskell CI).

@dterei dterei merged commit 8242baf into master Jul 28, 2025
21 checks passed
@dterei
Copy link
Member

dterei commented Jul 28, 2025

Thanks @andreasabel! Merged :)

@andreasabel andreasabel deleted the test-and-bench branch July 28, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants