-
Notifications
You must be signed in to change notification settings - Fork 58
Add kaipy to projects #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @wiltbemj, thanks for this submission! Sorry it's taken me so long to reply, I'm on vacation until the end of the month. I will review this when I get back in June. |
|
Actually it looks like you have a typo in your docs URL. Could you fix that in the meantime please? |
|
Sorry about that - I fixed the URL in the YAML file and the comment for this PR |
|
I'd like to have kaipy included in PyHC by the CEDAR/GEM meeting which begins on June 23rd. Will that be possible? |
|
I will certainly review it by then, yes 👍 |
_data/projects.yml
Outdated
| code: "https://bitbucket.org/aplkaiju/kaipy/src/master/" | ||
| contact: "Michael Wiltberger" | ||
| keywords: ["geospace","2D_graphics", "plotting", "hdf5", "local", "data_analysis", "specific"] | ||
| community: ["https://img.shields.io/badge/Good-brightgreen.svg", "Good"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this community line to "Partially met"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upated
|
@wiltbemj I've reviewed your package and I agree with your self evaluation. Kaipy will be a good addition to PyHC, thank you for being thorough. Two things though:
|
|
Hi Shawn,
Thanks for getting back to me on the PR.
1) I will update the PR to change the community line to "Partially Met" to
our PR description.
2) Acutally, I'm pleased to report that we are about a week away from a new
release of kaipy which will work for Python versions greater than 3.10. I
propose that I wait on updating the PR and change the python requirements
to match our new release so that you can work on including it in the
PyHC Environment. Does that make sense?
Take care,
Mike
Michael Wiltberger, Ph.D
NSF NCAR/HAO
3080 Center Green
Boulder, CO 80301
Ph: (303)497-1532
Fx: (303)497-2180
email: ***@***.***
There are only 10 types of people: those who understand binary and those
who don't.
…On Wed, May 28, 2025 at 1:10 PM Shawn Polson ***@***.***> wrote:
*sapols* left a comment (heliophysicsPy/heliophysicsPy.github.io#364)
<#364 (comment)>
@wiltbemj <https://github.com/wiltbemj> I've reviewed your package and I
agree with your self evaluation. Kaipy will be a good addition to PyHC,
thank you for being thorough. Two things though:
1. Please change your "community" line to "Partially met" to match
your own PR description.
2. Why do you require Python<=3.10? Is there a change in 3.11+ that
breaks your code? I ask because the PyHC Environment
<https://github.com/heliophysicsPy/pyhc-docker-environment> is already
on 3.11, so at present we could not include Kaipy (which would make it the
only published PyHC package NOT in the environment). I would request that
you add newer Python version support to the top of your task list before
the other three?
—
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMN67T73R2SEWCW4REVR733AXUZPAVCNFSM6AAAAAB3XCG7QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJXGA2DKMJUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@wiltbemj that's great news! Makes sense to me. So we'll wait about a week for that new release, then you'll update this PR, which will be my cue to confirm Python 3.11+ support and merge. At which point I'll add Kaipy to our PyHC Env (and to our PyHC Documentation Hub too, in case you hadn't heard of it). |
|
I saw your "updated" message, thanks, @wiltbemj. We appreciate the Python 3.11+ support. It looked like you commented without actually updating the file, so I pushed a couple commits to fix the Community badge and your code URL (since I noticed you migrated from Bitbucket to GitHub). Please let me know if I missed anything and we can push another update. Otherwise, I've approved this PR and will merge now. Kaipy will now appear in:
|
|
Hi Shawn,
Thanks for completing the PR and using our new Github repo. I was
slammed getting ready for CEDAR/GEM and didn't close the loop on this one
and really appreciate you taking the steps to finalize. I look forward to
continuing our engagement with PyHC.
Take care,
Mike
Michael Wiltberger, Ph.D
NSF NCAR/HAO
3080 Center Green
Boulder, CO 80301
Ph: (303)497-1532
Fx: (303)497-2180
email: ***@***.***
There are only 10 types of people: those who understand binary and those
who don't.
…On Tue, Jun 24, 2025 at 5:55 PM Shawn Polson ***@***.***> wrote:
Merged #364
<#364>
into main.
—
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMN67RYBQGGQ2SMTCOYJCT3FHCLXAVCNFSM6AAAAAB3XCG7QCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGMYDGMRWGYZTMMI>
.
You are receiving this because you were mentioned.Message ID:
<heliophysicsPy/heliophysicsPy.github.io/pull/364/issue_event/18303266361@
github.com>
|
Introduction
Kaipy is a Python package for analysis and visualization of simulation results from a scientific software package Kaiju. Kaiju includes the Multiscale Atmosphere-Geospace Environment (MAGE) model developed by the NASA DRIVE Center for Geospace Storms as well as other scientific software for simulation of heliospheric environments such as planetary magnetospheres and the solar wind.
PyHC Standards
Community: Partially Met
Documentation: Good
Testing: Partially Met
Software Maturity: Good
Python 3: Good
License: Good
Improvement Plan
Kaipy team will be working on the tasks in this order of priority to meet the highest standards of PyHC for future development: