Use AsyncFn in TwirpRouter and GrpcRouter
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi ! Thanks for the PR. I'll try to get a review today or tomorrow. |
vsiles
reviewed
May 21, 2025
| html_logo_url = "https://raw.githubusercontent.com/helsing-ai/twurst/main/docs/img/twurst.png" | ||
| )] | ||
| #![cfg_attr(docsrs, feature(doc_auto_cfg))] | ||
| #![feature(async_fn_traits)] |
Contributor
There was a problem hiding this comment.
@Tpt do we want to wait until these features are stablized ? IIUC they are still considered unstable
Collaborator
There was a problem hiding this comment.
Yes! Please, no unstable feature
Author
Contributor
There was a problem hiding this comment.
besides the unstable feature, the MR looks good ! Feel free to rebase it now, or wait until we can merge it. I'll leave the choice up to you.
Author
There was a problem hiding this comment.
Thanks for the review @vsiles, I'll go ahead and rebase it now.
Merged
surajk-m
force-pushed
the
asyncfn-trait-rust185
branch
from
628aa67 to
74b1871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54