Skip to content

Fix adding changed handler on observer creator #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rclai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix adding changed handler on observer creator #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,10 +450,10 @@ class DDPClient extends EventEmitter{
/**
* Adds an observer to a collection and returns the observer.
* Observation can be stopped by calling the stop() method on the observer.
* Functions for added, updated and removed can be added to the observer
* Functions for added, changed and removed can be added to the observer
* afterward.
*/
observe(name, added, updated, removed) {
observe(name, added, changed, removed) {
var self = this;
var observer = {};
var id = self._getNextId();
Expand All @@ -467,7 +467,7 @@ class DDPClient extends EventEmitter{
Object.defineProperty(observer, "_id", { get: function() { return id; }});

observer.added = added || function(){};
observer.updated = updated || function(){};
observer.changed = changed || function(){};
observer.removed = removed || function(){};

observer.stop = function() {
Expand Down