Require buffer #133
Merged
Require buffer #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n used in the web
Webpack 5 removed automatic support for node polyfills so you now can't access the node `Buffer` global in the browser any more - you have to `require` it first. I've added Feross' [Buffer polyfill](https://www.npmjs.com/package/buffer) as a dependency and `require`d it in the non-cli/test files that use Buffer directly. If running on node you'll get node's Buffer, if it's the browser you get the polyfill. It's not worth replacing `Buffer` with `Uint8Array`s entirely because there's no equivalent API to [Buffer.allocUnsafe](https://nodejs.org/api/buffer.html#buffer_static_method_buffer_allocunsafe_size) so it'd be a big performance hit.
…pendency function
hildjj
force-pushed
the
require-buffer
branch
from
b3ae5b7 to
6815938
Compare
hildjj
added
the
major-version
Owner
Author
|
I am likely to merge this today, but doing a release will take some work, since I want to try and automate that process. But I need this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to need more work before it's ready