Assembly mapping object #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Assembly Mapping Object (0xEB) to enable dynamic assemblies in the ABCC driver API. The implementation allows for mapping application data instances (ADIs) to assembly instances with support for both static and dynamic configurations.
Key changes:
- New assembly mapping object implementation with instance and object command processing
- Configuration options for dynamic instances, name strings, and maximum ADI maps
- EtherNet/IP producing/consuming instance callback functions
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/host_objects/assembly_mapping_object.h | Header file defining public interfaces for Assembly Mapping Object initialization and command processing |
| src/host_objects/assembly_mapping_object.c | Core implementation of Assembly Mapping Object with instance/object command handlers |
| src/abcc_api_handler.c | Removed blocking error directive to enable Assembly Mapping Object support |
| src/abcc_api_config.h | Added configuration macros for Assembly Mapping Object features |
| src/abcc_api_command_handler.c | Added routing for Assembly Mapping Object commands |
| inc/host_objects/abcc_api_command_handler_lookup.h | Added EtherNet/IP producing/consuming instance attribute definitions and callbacks |
| inc/abcc_api.h | Added ASM_InstanceType structure and callback function declarations |
| abcc-driver-api.mk | Added assembly_mapping_object.c to build sources |
| abcc-driver-api.cmake | Added assembly_mapping_object files to CMake build configuration |
Comments suppressed due to low confidence (1)
src/host_objects/assembly_mapping_object.h:1
- Corrected spelling of 'ojbect' to 'object'.
/*******************************************************************************
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cldhms
requested changes
Jan 8, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cldhms
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Assembly Mapping Object