Skip to content

Conversation

@waja
Copy link
Contributor

@waja waja commented Dec 9, 2024

@hoellen
Copy link
Owner

hoellen commented Dec 10, 2024

@waja I need some time to test this properly. What tests have you already done?

@waja
Copy link
Contributor Author

waja commented Dec 10, 2024

@hoellen I did build it locally and spin of the container. Maybe it might be a good idea to run the Github build pipeline also on PRs, which might give you a better indication if changes are okay before merging to master.

@waja
Copy link
Contributor Author

waja commented Dec 10, 2024

Maybe it might be a good idea to run the Github build pipeline also on PRs, which might give you a better indication if changes are okay before merging to master.

I've prepared #97 to solve this

@hoellen hoellen merged commit ae0277a into hoellen:master Dec 13, 2024
@waja waja deleted the alpine321 branch December 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants