Skip to content

Improve init method to support associative array prompt #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TDannhauer wants to merge 1 commit into from
Closed

Improve init method to support associative array prompt #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions lib/Horde/Form/Type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,9 +963,23 @@ class Horde_Form_Type_country extends Horde_Form_Type_enum
*
* function init($prompt = null)
*/
public function init(...$params)
{
$prompt = $params[0] ?? null;
public function init(...$params)
{
// When call_user_func_array passes an associative array like ['prompt' => 1],
// and the function uses ...$params, PHP passes the array as a single argument,
// but $params itself becomes the associative array directly (not $params[0])
// So we need to check if $params itself has the 'prompt' key
$prompt = null;
if (is_array($params) && isset($params['prompt'])) {
// $params is directly the associative array with 'prompt' key
$prompt = $params['prompt'];
} elseif (isset($params[0]) && is_array($params[0]) && isset($params[0]['prompt'])) {
// $params[0] is an array with 'prompt' key (fallback for numeric arrays)
$prompt = $params[0]['prompt'];
} elseif (isset($params[0]) && !is_array($params[0])) {
// Direct value passed as first argument
$prompt = $params[0];
}
parent::init(Horde_Nls::getCountryISO(), $prompt);
}

Expand Down
Loading