-
Notifications
You must be signed in to change notification settings - Fork 6
Add a Github Actions Workflow for integration testing #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Working towards #346
gcapes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good step in the right direction. I'm not sure how to test this but I can see a couple of issues/improvements:
- This is pulling workflows from another repo. I think they should live within the MatFlow repo. Indeed the groups one already does, and could be extracted from inline code to a separate code file which I guess could then be run by this action?
- The
hello.yamlworkflow uses a python script and needs a full path to it. https://github.com/LightForm-group/matflow-user-documentation/blob/master/hello.yaml#L22. I'm not sure how you get round that but again perhaps if it was a part of the matflow repo, then after cloning in the action, we could specify a path? I can't think of a nice implementation but I guess you could do something withsedto replace the file path?
|
I've raised that path problem as a bug. I'll have a think about how to hack it... though I don't like that! |
|
Surgery, thy name is PERL! run: |
perl -pi -e 's/$ENV{REPLACE}/$ENV{PWD}/g' *.yaml
working-directory: userdocs
env:
REPLACE: /home/mbexegc2/projects/lightform/matflow-user-documentation |
|
And with that change, we now have the integration test of (some of) the user documentation workflows working. |
|
@gcapes My intention would be to add more bits to this to test other key workflows. The one that exists explicitly is to test the user documentation repo. |
Working towards #346
Currently this just runs the
helloandgroupsworkflows fromLightForm-group/matflow-user-documentation.