-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add load case rotation #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Rotation matrix may be specified to rotate the load case.
Changed 'rotation' key to 'rotation_matrix' for use in damask_parse.
aplowman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Just some minor changes.
|
Failures are unrelated, and due to upstream failures in the hpcflow release workflow, which means there hasn't been a |
Co-authored-by: Adam Plowman <adam.jp@live.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial review should have been been more thorough 😄 Just tried it out and it doesn't work because damask-parse's write_load_case is expecting rotation_matrix, and it's currently getting rotation.
So, two things to do:
- Where you have
rotation_matrixin the various_method_argsdicts, change this to justrotation. This is just meant to be a record of how the class method was initially parametrised, and so should reflect the method signature - In the method
LoadCase.create_damask_loading_plan, add something like:dct["rotation_matrix"] = dct.pop("rotation", None)to rename therotationkey appropriately.
Thanks!
That makes sense, I got the wrong end of the stick and assumed the |
aplowman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks. It works!
But let's not merge this until I've fixed the hpcflow release workflow.
Added an argument to the LoadCase class that allows for the load to be rotated by an arbitrary rotation matrix.